Add testing framework for three.js examples #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methuselah96
changed the title
Methuselah96
force-pushed
the
three-ts-examples
branch
from
355cb70
to
37a47ad
Compare
Methuselah96
force-pushed
the
three-ts-examples
branch
from
2e52825
to
f0c9aa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We currently have some integration tests that are basically some of the three.js examples converted to TypeScript. The problem is that there is no system to keep these up-to-date.
What
This PR adds a system for keeping those up-to-date by using Git patches.
Checklist
master, next goesdev)